search

lilypuree / Decorative-Blocks

A small mod that adds several new decorative blocks.
MIT License
27 stars 25 forks source link

Quilt support #76

Open SplendidAlakey opened 2 years ago

SplendidAlakey commented 2 years ago

MC 1.19.2 QSL 4.0.0 beta 9, provides Fabric API 0.60.0 Note, Quilt loader can also use regular Fabric API, which lets the mod work, however, QSL is needed for Quilt exclusive mods, so I have to use it.

Quilt is a modloader that natively supports all Fabric mods with rare exceptions, and currently Decorative Blocks causes a crash on startup. Could you please look into it? Usually, adding support for Quilt doesn't even require maintaining a separate version, Fabric one should work on both. However, I'll understand if you decide not to do it.

It might also be a problem on Quilt's side, so let me know if it's not something you can fix.

Logs: https://gist.github.com/SplendidAlakey/7541144c23df3740dcb01bbbc1a0d5ef

OroArmor commented 2 years ago

I just looked into this issue and it is caused by not using the Fabric API to register the fuel times for your item/tags. This can probably be easily fixed by creating your blocks and items within the static class initialization instead of through an init method, which isn't needed.

EightBlade commented 2 years ago

I'm having this problem, too. The crash on startup.

greensad commented 2 years ago

Also chiming in that this is happening for me. Here's a log with just the barest configuration loaded: -Decorative Blocks 3.0.0 (1.19.2) -Quilted Fabric API (qfapi-4.0.0-beta.20_qsl-3.0.0-beta.21_fapi-0.66.0_mc-1.19.2) Log: https://mclo.gs/JDZqCXK

artemisSystem commented 2 years ago

@lilypuree are you able to look into this? It seems the issue is just the way fuels are registered, according to OroArmor.