search

lilypuree / Decorative-Blocks

A small mod that adds several new decorative blocks.
MIT License
27 stars 22 forks source link

Register burnables properly on fabric #81

Open artemisSystem opened 1 year ago

artemisSystem commented 1 year ago

Fix #76

This also creates a s_that_burn tag for each wood item and use that for registration, so that warped and crimson ones don't burn (like all their wooden items in vanilla)

artemisSystem commented 1 year ago

@lilypuree do you have some time to look over this PR please? It fixes the quilt incompatibility

ghost commented 1 year ago

Implementing this quick fix would be much appreciated. I'd build the fixed version myself but am dumb with computers and have a step fail every time :(

Fuzzhamster5 commented 1 year ago

@lilypuree please could you do this as my quilt modpack REALLY needs this mod

TimDev9492 commented 1 year ago

Bump

Jothbot commented 1 year ago

bump

Fuzss commented 1 year ago

@artemisSystem Your implementation does not work, you cannot use tags. Fuel registration happens during mod setup, while tags are initialized from the current data pack during world loading. During mod setup tags are always empty, so you are essentially registering nothing to the fuel registry.

artemisSystem commented 1 year ago

are you sure? did you test it? it's been a while but i think i remember it working perfectly. i'm assuming what's happening is it's registering the tag itself, and it's looked up in-world when needed

Fuzss commented 1 year ago

Nvm, it seems like Fabric Api handles that case by clearing caches every time tags are loaded. I just noticed that when trying TheWinABagel's fork (assuming they didn't make an error in adapting your PR) that only beams do work as fuel, palisades, seats and supports don't. Not sure what's the cause then and if your PR is affected, too.

unilock commented 1 year ago

@Fuzss Looks like TheWinABagel's fork only adds the relevant block tags, not item tags. (https://github.com/TheWinABagel/Decorative-Blocks/commit/e13290bf6e7363a927de8aa235b1565f43c7798b#diff-f1afe8d18a5d2cf47951c181edce2c948583348d3ec780f1841fc9d8b1111af3) (@TheWinABagel)

TheWinABagel commented 1 year ago

Whoops, will fix and upload a new version. I really need to figure out git one of these days...