search

lim-jt / pe

0 stars 0 forks source link

Specificity of error message for date #6

Open lim-jt opened 5 days ago

lim-jt commented 5 days ago

The input validation of date is not specific enough as while it is required to be in YYYY-MM-DD format, 2021-13-28 is a format error (reason: MM should be in 1..12) but 2021-02-30 is an invalid input (reason: February doesn't have 30 days). However the output for both is the same when inputting in commands.

soc-pe-bot commented 1 day ago

Team's Response

Thanks for your feedback!

For our context, we did not explicitly specify limitations like MM having to be [1, 12], so we feel that both inputs could still be classified as invalid inputs, and that only dates that are not in the form YYYY-MM-DD should be classified as invalid formats. As such, we feel that this error message is sufficient for the current iteration.

However, we understand that users could perhaps want more specific error messages, so this could be improved upon in subsequent iterations.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]