search

lima-vm / alpine-lima

Create an alpine based image for lima
Apache License 2.0
40 stars 26 forks source link

Refactor: rename nerdctl to nerdctl-full #105

Closed afbjorklund closed 1 year ago

afbjorklund commented 1 year ago

Since the bundle package also contains other software.

These are also available as regular Alpine packages.

afbjorklund commented 1 year ago

@jandubois : broke this out from the "nerdctl" edition

AkihiroSuda commented 1 year ago

I'm not sure about this. I'd say "nerdctl-full" refers to the upstream nerdctl-full distribution ( https://github.com/containerd/nerdctl/releases/download/v1.4.0/nerdctl-full-1.4.0-linux-amd64.tar.gz )

afbjorklund commented 1 year ago

Currently we download "nerdctl-full", and rename it to "nerdctl"

nerdctl-$(NERDCTL_VERSION)-$(ARCH):
        curl -o $@ -Ls https://github.com/containerd/nerdctl/releases/download/v$(NERDCTL_VERSION)/nerdctl-full-$(NERDCTL_VERSION)-linux-$(ARCH_ALIAS).tar.gz
jandubois commented 1 year ago

I've merged this change because it makes sense to normalize the name.

It feels a bit pointless though, as rd is the only edition that uses it, and it is no longer built out of this repo, but from https://github.com/rancher-sandbox/alpine-lima.

And then we have #77 about letting Lima bundle nerdctl, just like for all other images.

Anyways, I've been wondering if I should remove the rd specific config options from this repo and maintain them purely in the downstream fork. What do you think @AkihiroSuda ?

AkihiroSuda commented 1 year ago

rd

SGTM