search

lima-vm / alpine-lima

Create an alpine based ISO image for lima
Apache License 2.0
42 stars 28 forks source link

Don't run nerdctl with suid in nc #106

Closed afbjorklund closed 1 day ago

afbjorklund commented 1 year ago

This is a Rancher Desktop specific setting

Running nerdctl requires root, in Alpine

afbjorklund commented 1 year ago

@jandubois : broke this out from the "nerdctl" edition

jandubois commented 1 year ago

I'm happy to merge this, if you need this for any other edition, but it should not be enabled for the rd edition because we run nerdctl via sudo already. Maybe it makes sense to change it; I have to think about it.

I'm fine with adding more editions to this repo, if you think they will be useful. But as I mentioned in the other PR, I'm thinking about removing the rd edition from this repo because it is maintained in a fork. Mostly to avoid the churn in this repo, but also to be able to have rancher-desktop maintainers be able to review/merge PRs.

jandubois commented 1 day ago

Closing this because #130 removes the setting to install nerdctl.