search

limbo-works / Limbo.Umbraco.Tables

Table editor for Umbraco.
https://packages.limbo.works/limbo.umbraco.tables/
MIT License
6 stars 8 forks source link

Added rte configuration #14

Closed AaronMorf closed 1 year ago

AaronMorf commented 1 year ago

Allows to change the rte config

jdpnielsen commented 1 year ago

Testet out this patch and it works really well!

abjerner commented 1 year ago

Hi @AaronMorf

We don't really have a lead developer or an internal "owner" of this package, which is why this PR hasn't had any replies from us.

The changes work nicely, but I also notice that the PR fails to set a default value for the RTE configuration. Umbraco' RTE property editor, which the package is using, does have a fallback - but that fallback is different from the configuration this package have used so far.

This is therefore a breaking. Not a big one though. I and maybe so little that we don't really care about it in the end. But I need to have a chat with my colleagues on how best to proceed.

I'll hope to be back with more information soon 😉

abjerner commented 1 year ago

Hi @AaronMorf

We had a chat about this PR, and decided to merge it 👍

It is a breaking change for the reasons that I mentioned in previous comment, but we're fine with having this part of a new v1.1.0 release 😉