search

limbo-works / Limbo.Umbraco.Tables

Table editor for Umbraco.
https://packages.limbo.works/limbo.umbraco.tables/
MIT License
6 stars 8 forks source link

Unable to add new columns after 11th column created using Version: 1.1.3 #31

Closed jattwood closed 4 months ago

jattwood commented 7 months ago

Very strange an intermittent issue with Version: 1.1.3 on Umbraco 11 that we have discovered with tables greater than 11 cells when the Limbo tables are used in the block grid. I can't confirm if this happens when not in the block grid, but I would image this issue exists there as well. Under certain scenarios, we are unable to add additional columns or delete rows when these conditions exist. No errors outputted to console.

To replicate: 1) Create a table with 1 row 12 cells.

image

2) Label each cell with values. I use number 1 through 11, leave the 12th cell with no value. 3) Click create 4) Reopen the table block from your grid 5) Try to create another column, "Add Column" button does not work, delete row does not work

image

Even if you add a value to your 12th cell, you can't add additional values. Also the delete row function does not work during this scenario.

You can bump the table to make it start working again by deleting a column, but then you lose the data in that entire column across the board, so it's not a viable workaround.

jattwood commented 6 months ago

Just working with this again. Regardless of what we do, we are unable to build a table greater than 12 columns. To recreate, just try to add new columns to a new table - click add column 11X to replicate. At the 12th column, you are unable to add any more columns.

jattwood commented 6 months ago

Can you please update line 28 in TableDataEditor.js to a number larger than 12? Maybe 24?

image

hfloyd commented 4 months ago

I'm bumping up against this issue today. As per a prior conversation... @abjerner noticed the limitation and wasn't sure why it was in place, which leads me to believe it could be removed without any ill effects.

jattwood commented 4 months ago

Hey Heather! Yeah I did a PR fix for this. Just waiting on it's integration and release as well! Cheers.

hfloyd commented 4 months ago

Ah, I see your two PRs: https://github.com/limbo-works/Limbo.Umbraco.Tables/pull/32 https://github.com/limbo-works/Limbo.Umbraco.Tables/pull/33

I'm going to try merging your fix in the "v1" branch, since I need it fixed for a v10 site. (I just compile my own custom NuGet package from these fixes since I usually am too impatient to wait for official releases. 😉

abjerner commented 4 months ago

Sorry for the lack of action. I'm caught up in too many different things, so even small issues like this end up not being fixed/merged for waaaay too long. I'll try to find some time looking into this soon 😉

abjerner commented 4 months ago

I've now pushed new releases for both Umbraco 10 and 13:

jattwood commented 4 months ago

Awesome thanks. Heather - for Sprott lol...

jattwood commented 4 months ago

Thank you!