limcheekin / jquery-validation-ui

JQuery Validation UI Plugin - Client Side Validation without writing JavaScript
http://limcheekin.github.io/jquery-validation-ui/
Apache License 2.0
20 stars 18 forks source link

Fix issue #17: Wire dependencies and handle command objects in remote validation #26

Open jonroler opened 11 years ago

jonroler commented 11 years ago

I also ran into the issue reported in issue #17. My fix is nearly identical to the one proposed by Pascal in the comments for issue #17. The code now wires up spring dependencies into the newly created validatable object before doing the validation which is what would normally be the case for a command object on the server side. Also, it checks to see if the object is a domain object or not before calling isAttached() on it since isAttached() won't be present on command objects. It looks like maybe Pascal never sent you a pull request. Can you please pull this fix in?

limcheekin commented 11 years ago

Thanks for sent me the fix. My old laptop just busted and R.I.P. There will be delay for release of the fix till I got my new laptop :(

jbowen7 commented 11 years ago

I had also been working on #17 but I wasn't sure how to submit a pull request. Assuming I cloned this repo, can I just do a commit -a -m"Fixed fooness" ?

Thanks jon

jonroler commented 10 years ago

Can we please look at pulling this fork into master and putting out a new release? I spent quite a bit of time on this, updated the docs with the changes, etc. It's been 9 months since I committed, and it would be very helpful to have this stuff in the official release of this plugin. My project relies on these changes working, and I believe others would benefit as well.

Thanks,

--Jon

limcheekin commented 10 years ago

Hi Jon,

Appreciate your contributions and sorry for the slow response. I am on a business trip abroad now till end of the month and will find time to merge your changes and release new version once I back home.

// Chee Kin