limdoglim / google-breakpad

Automatically exported from code.google.com/p/google-breakpad
0 stars 0 forks source link

allow callers to override SourceLineResolver behavior #89

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
We should allow callers of MinidumpProcessor to supply their own version of
SourceLineResolver, providing the current implementation as a base to build
on.  This would be useful in any situation where loading a full symbol file
into the calling process is not desired.

Still TBD: if we do this, is the SymbolSupplier interface still useful?  It
would be possible for a custom implementation of SourceLineResolver to load
symbol files any way that it wants to, without having to return a local
file path as a string.

Original issue reported on code.google.com by bry...@gmail.com on 4 Dec 2006 at 10:57

GoogleCodeExporter commented 9 years ago
This patch factors out an abstract interface to SourceLineResolver, and makes 
the
header for the concrete implementation public.  I didn't make any changes to the
SymbolSupplier functionality.

Original comment by bry...@gmail.com on 4 Dec 2006 at 11:05

Attachments:

GoogleCodeExporter commented 9 years ago
patch version 2

Original comment by bry...@gmail.com on 11 Dec 2006 at 9:49

Attachments:

GoogleCodeExporter commented 9 years ago
Looks like this was fixed in r83.

Original comment by ted.mielczarek on 3 Jul 2007 at 12:41