search

limedocs / limedocs-wiki-converter

Generate HTML & PDF documentation from you Github wiki or any other markdown-based wiki
MIT License
43 stars 65 forks source link

Adding support for Data URI based images #6

Closed computamike closed 5 years ago

computamike commented 6 years ago

Github does allow for images to be inserted as a Data URI - these images currently break when exporting the wiki, as the addresses do not start with http(s).

This is a quick fix that passes any data: addresses directly through to the rendered image control.

mattallty commented 5 years ago

Thanks but I cannot accept your contribution, this PR changes even the name of the npm package (!!)

computamike commented 5 years ago

Thanks @mattallty - I believe that this was a fix applied to a fork of your project - I don't even recall making this pull request. I will raise an issue around this, refactor this code fix and retry. Thanks for taking a look

computamike commented 5 years ago

@mattallty - Further information :

Attempting to for this repository is somewhat confusing - I had (at some point) forked this repo - but when I access this repo now it gives this :

screencast

So for some reason - and I'm not sure what that reason is - forking this repo managed to fork a different repo - meaning that the pull request was made against this strange fork. My changes are preserved on my own branch - so I have attempted a second fork, and will retry my code fix.