search

limegrow / ingenico-m2-payments

2 stars 15 forks source link

Compatibility with Magento 2.4.4 / Php 8 #36

Open gdvisser opened 2 years ago

gdvisser commented 2 years ago

This module is not compatible with php 8 as it is using an outdated version of league/iso3166. This needs to be updated for Magento 2.4.4 that requires php 8.1: https://devdocs.magento.com/guides/v2.4/install-gde/system-requirements.html.

Bumping from version 2.1.5 to 3.0.0 would already provide this. And this has minimum impact because only a few code changes: https://github.com/thephpleague/iso3166/compare/2.1.5...3.0.0.

akosglue commented 2 years ago

I confirm, just faced this issue.

gdvisser commented 2 years ago

@olegisk @raidoa I have created a pull request to fix this. Can you please review and create a new tag? https://github.com/limegrow/ingenico-m2-payments/pull/37

akosglue commented 2 years ago

any plans to merge this?

akosglue commented 2 years ago

is this module removed from magento marketplace because of the incompatibility with magento 2.4.4?

bramstroker commented 2 years ago

Any update on this one? This is blocking upgrades to 2.4.4 for our projects.

akosglue commented 2 years ago

It seems to be updated in this fork: https://github.com/gdvisser/ingenico-m2-payments

but yeah, do you want to go on with a fork?

redo-interactive commented 2 years ago

Hi, @olegisk @raidoa do you think it will be possible to do some kind of upgrade of the module, to be compatible with m2.4.4 and php 8.1? Kind regards

gdvisser commented 2 years ago

It seems to be updated in this fork: https://github.com/gdvisser/ingenico-m2-payments

but yeah, do you want to go on with a fork?

You can use this fork as temporarily fix. I've already created a pull request: https://github.com/limegrow/ingenico-m2-payments/pull/37.

Also called Limegrow to merge this. Their response is that they need approval from Ingenico for this. So it will also be helpful to reach out to them to give this priority.

But seems like development is on hold while Ingenico is working on a new module.

akosglue commented 2 years ago

@gdvisser do you mean this repo as 'new module'?

https://github.com/wl-online-payments-direct/plugin-magento

or is this something else?

because the docs is not really clear:

https://epayments-support.ingenico.com/en/integration-solutions/plugins/magento-2

VS

https://support.direct.ingenico.com/en/documentation/plugins/magento/

gdvisser commented 2 years ago

I don't know exactly. Limegrow was telling me that there's coming a new module that will replace theirs, that's all I know.

But it would be nice if this module will be maintained for the time being. Especially when it's a small one line PR like this.

Best is if you let the customer of Ingenico reach out to them and refer to this PR that needs to be merged to be able to do necessary updates.

redo-interactive commented 2 years ago

@gdvisser I have tested your update, and unfortunately, it still crashes on the cart and checkout page and in the admin panel. You have tested it with magento 2.4.4 and php8.1?

gdvisser commented 2 years ago

@gdvisser I have tested your update, and unfortunately, it still crashes on the cart and checkout page and in the admin panel. You have tested it with magento 2.4.4 and php8.1?

Have you updatet composer? What version does composer.lock has for league/iso3166? Try composer update ingenico/m2-payment --with-dependencies.

magento2dev commented 2 years ago

does anyone find a way to update to PHP 8 ? thank you

gerarddevisser commented 2 years ago

does anyone find a way to update to PHP 8 ? thank you

You can create a composer patch containing this diff: https://github.com/limegrow/ingenico-m2-payments/pull/37/files. Then it should work with PHP 8.

magento2dev commented 2 years ago

does anyone find a way to update to PHP 8 ? thank you

You can create a composer patch containing this diff: https://github.com/limegrow/ingenico-m2-payments/pull/37/files. Then it should work with PHP 8.

Thanks but sadly there are a lot of PHP 8 issues in this module too : ingenico/ogone-sdk-php (dependancy of ingenico/m2-payment. How did you fix this ?

Thank you

gerarddevisser commented 2 years ago

You can create your own composer patch to fix compatibility.

Cloudy777 commented 2 years ago

Even when patching, the ingenico/ogone-client is not compatible with php8.1 . PHP 7.4 has EOL in about 1 month..

akosglue commented 1 year ago

this could possible be an alternative: https://wiki.worldline-cms.com/en/Cms/Magento#magento-24-amasty-plugin-direct

timxsarus commented 1 year ago

Is there any roadmap/news on the php8 compatibility?

raidoa commented 1 year ago

Hi!

I've missed some notifications from Github and thus bit late to the discussion.

This module and also the required dependencies (core-library + SDK) will not get an official update for PHP8+ compatibility. It's recommended to consider the possible options and new module from this page: https://support.direct.worldline-solutions.com/en/documentation/plugins/magento/