limesquid / favicon-thief

Find the best favicon for a given URL
MIT License
4 stars 0 forks source link

findIcon hangs forever #17

Closed kamilmielnik closed 1 year ago

kamilmielnik commented 1 year ago

found in https://github.com/limesquid/favicon-thief/pull/6

kamilmielnik commented 1 year ago
🌐 barnesandnoble.com
Error: socket hang up
    at connResetException (node:internal/errors:705:14)
    at TLSSocket.socketCloseListener (node:_http_client:467:25)
    at TLSSocket.emit (node:events:525:35)
    at node:net:301:12
    at TCP.done (node:_tls_wrap:588:7) {
  code: 'ECONNRESET'
}
kamilmielnik commented 1 year ago

It fails here.

Could it be because of x-content-type-options: nosniff header set by barnesandnoble.com?

edit: no, it should not.