limetech / dynamix

14 stars 5 forks source link

Expanded Shares page #17

Open limetech opened 9 years ago

limetech commented 9 years ago

Expand the Shares page:

This makes the Shares page have two tabs: “Disk Shares” and “User Shares”

Slight change to the AFP/SMB/NFS/Export colums:

This way, we display same columns for both disk shares and user shares.

Eventually also add a Global Share Settings item called “Use disk id for comment”. If set to Yes, then the “Comment” field for disk shares, which is just a Samba config var, is set to the disk id string.

bergware commented 9 years ago

I'll have a look at it tomorrow (Friday).

bergware commented 9 years ago

There are two known caveats at the moment:

  1. Drag and drop functionality in the user name list doesn't work in Internet Explorer
  2. Changing the access rights in AFP makes emhttp crash o(

I am looking for a replacement method to do the drag and drop functionality, but haven't found anything suitable yet. Your ideas are welcome.

Doing an investigation into the emhttp crash, it reports:

Nov 25 22:00:49 vesta emhttp: userAccess.0 not found Nov 25 22:00:49 vesta kernel: emhttp[3411]: segfault at 0 ip 00002b4add097dba sp 00007fff8e4867e8 error 4 in libc-2.17.so[2b4adcf61000+1bf000]

Now "userAccess.0" (which is root) is not being modified at all...

My proposal: keep this security enhancement out for the moment until all kinks are addressed. It can always be offered as an optional plugin at a later stage and intergrated - if you wish - in an upcoming version.

limetech commented 9 years ago

My proposal: keep this security enhancement out for the moment until all kinks are addressed. It can always be offered as an optional plugin at a later stage and intergrated - if you wish - in an upcoming version.

Agreed.

bergware commented 9 years ago

I did some further development here, but still need to resolve a couple of points. I would say status stays as is: it can be offered as an optional plugin and may be integrated in a upcoming version.