search

limetech / dynamix

14 stars 5 forks source link

Install Plugin browse local file system #37

Open limetech opened 9 years ago

limetech commented 9 years ago

On the Install Plugin page (tab) there are two ways to select the plg file: by pasting a URL into a text box and by navigating the server file system.

It seems to me there is no value in navigating the server file system. Instead it should be a control that lets you navigate the file system of the computer running the browser. For example, it should let me navigate to the 'Download' folder on my local windows PC, select a plg file, and then upload that to the /boot/config/plugins folder on the server. Make sense?

jonpanozzo commented 9 years ago

Agreed on this and Eric and I are working on a file upload control that's a little more advanced than the standard HTML input type of "file" that will provide a single button to click to browse the local filesystem of the client device, and when a file is selected and OK is clicked, the file is immediately uploaded to the system (no additional clicks required). On Dec 9, 2014 8:30 PM, "tom mortensen" notifications@github.com wrote:

On the Install Plugin page (tab) there are two ways to select the plg file: by pasting a URL into a text box and by navigating the server file system.

It seems to me there is no value in navigating the server file system. Instead it should be a control that lets you navigate the file system of the computer running the browser. For example, it should let me navigate to the 'Download' folder on my local windows PC, select a plg file, and then upload that to the /boot/config/plugins folder on the server. Make sense?

— Reply to this email directly or view it on GitHub https://github.com/limetech/dynamix/issues/37.

bergware commented 9 years ago

Yes, this makes sense, certainly in combination with a single click system.

Right now , I create a separate folder on the server to store the plg files, but most users would want to do this on their own PC.

One pitfall, editing a PLG file on a windows machine with the wrong editor (read notepad) destroys the linux file format.

jonpanozzo commented 9 years ago

Serious question: other than plugin authors who should know better to use a good editor like notepad++ if on Windows, who is editing PLG files by hand before installation?

eschultz commented 9 years ago

I guess we can always run the 'fromdos' command on the uploaded plg to make sure the line endings are Unix.

limetech commented 9 years ago

One pitfall, editing a PLG file on a windows machine with the wrong editor (read notepad) destroys the linux file format.

Has anyone tried it? The plugin script uses simplexml_load_file() and I bet it handles either type of line endings correctly.

I guess we can always run the 'fromdos' command on the uploaded plg to make sure the line endings are Unix.

If simplexml_load_file() does not handle line endings correctly, this should be fixed in plugin script because the flash share is exported and someone on a windows system could navigate the directories on the share and edit a file directly.

jonpanozzo commented 9 years ago

Not recently. I will give it a go here in a sec to see what happens…

Sent from Windows Mail

From: tom mortensen Sent: ‎Wednesday‎, ‎December‎ ‎10‎, ‎2014 ‎12‎:‎11‎ ‎PM To: limetech/dynamix Cc: jonp@lime-technology.com

One pitfall, editing a PLG file on a windows machine with the wrong editor (read notepad) destroys the linux file format.

Has anyone tried it? The plugin script uses simplexml_load_file() and I bet it handles either type of line endings correctly.

I guess we can always run the 'fromdos' command on the uploaded plg to make sure the line endings are Unix.

If simplexml_load_file() does not handle line endings correctly, this should be fixed in plugin script because the flash share is exported and someone on a windows system could navigate the directories on the share and edit a file directly.

— Reply to this email directly or view it on GitHub.

bergware commented 9 years ago

I did a quick test, simpleXML takes both formats unix and windows. No real issue here.

jonpanozzo commented 9 years ago

Nice! Saved me the test! Thanks Ronald!

Sent from Windows Mail

From: bergware Sent: ‎Wednesday‎, ‎December‎ ‎10‎, ‎2014 ‎1‎:‎03‎ ‎PM To: limetech/dynamix Cc: jonp@lime-technology.com

I did a quick test, simpleXML takes both formats unix and windows. No real issue here.

— Reply to this email directly or view it on GitHub.