search

limetext / lime

Open source API-compatible alternative to the text editor Sublime Text
http://limetext.github.io
BSD 2-Clause "Simplified" License
15.3k stars 1.06k forks source link

Code cleanup: Replace BufferChangedCallbacks with BufferObservers (#427) #447

Closed MontakOleg closed 9 years ago

erbridge commented 9 years ago

The build is failing:

backend/loaders/json.go:48: cannot use set (type text.RegionSet) as type text.BufferObserver in argument to b.AddObserver:
    text.RegionSet does not implement text.BufferObserver (missing Erased method)
backend/loaders/json.go:68: cannot define new methods on non-local type text.RegionSet
backend/loaders/json.go:72: cannot define new methods on non-local type text.RegionSet
coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.07%) when pulling 87634e5044e23248945d178ddd845ed59031d701 on MontakOleg:master into b4b0dc0eb74ba0f9d911445e5a6555e88c5c5e7a on limetext:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.03%) when pulling 898725e0ed356d97836aae588baba8dc529204a4 on MontakOleg:master into b4b0dc0eb74ba0f9d911445e5a6555e88c5c5e7a on limetext:master.

zoli commented 9 years ago

LGTM, Thanks.