limetext / lime

Open source API-compatible alternative to the text editor Sublime Text
http://limetext.github.io
BSD 2-Clause "Simplified" License
15.3k stars 1.06k forks source link

disable console on start, add menu for show/hide console and statusbar #472

Closed ghost closed 9 years ago

ghost commented 9 years ago

currently I work on an own editor in python also using qml, and I have explored this feature which is great. Have added the shortcut for hiding console from sublime text (Ctrl+)`, I hope its the correct shortcut. also disabled the console on start, because when Sublime Text starts at the first time there is no console.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.06%) when pulling 95fd54ce4d88ff3c6c328c40383ae0e0b000892d on jchpi:master into 76b9cb228a5416f52ef89bcd288c6c5a95b0070e on limetext:master.

erbridge commented 9 years ago

IMO, this should be set up as a command in the backend, and bound to the keyboard shortcut there. What do you think @limetext/owners?

zoli commented 9 years ago

I agree this should be done via show_panel(#42) command but I think we can merge this for now until #42 is implemented.

quarnster commented 9 years ago

Getting show_panel (#42) implemented is a bit of a larger task though as it will have to be able to deal with any odd number of panels and not just the console specifically.

IMO it's better to accept improvements even if they are a subset of what the full solution should be so I'm ok with this PR. Can't try it out locally but from a code POV LGTM.

zoli commented 9 years ago

LGTM, Thanks. I wasn't able to test the results sooner due to #474.