search

limetext / lime

Open source API-compatible alternative to the text editor Sublime Text
http://limetext.github.io
BSD 2-Clause "Simplified" License
15.3k stars 1.06k forks source link

Fix fg/bg for newline lineno render. Added comment about redundant calls. #476

Closed kennylevinsen closed 9 years ago

kennylevinsen commented 9 years ago

This fixes the attributes used by the extra call to renderLineNumber, fixing #469.

I also added a comment about the redundant calls to renderLineNumber: Every line with content that isn't the last in the view will have renderLineNumber called twice. That tickles my OCD's, and my OCD's hate being tickled.

kennylevinsen commented 9 years ago

The failure is the usual race on settings on init.

A (very tired) theory about the race is the Editor instance being reused between test runs, so that it is actually just complaining about a previous frontend test having completed init, followed by a second run touching the settings? In that case, adding a DestroyEditor (which will be called after all tests touching the editor manually, and on front-end shutdown) should fix it. (Some might suggest against the "global state in lib", though, suggesting for the backend to keep state as instance data.)

My brain is currently toast, but it's a theory. I think. Maybe. We can flip a coin on it?

zoli commented 9 years ago

LGTM, Thanks.