search

limetext / lime

Open source API-compatible alternative to the text editor Sublime Text
http://limetext.github.io
BSD 2-Clause "Simplified" License
15.3k stars 1.06k forks source link

qml main.go file decomposition #504

Closed bwiggs closed 9 years ago

bwiggs commented 9 years ago

The qml/main.go was getting pretty large, so I moved all the different types to their own files and cleaned up the imports, var, and const declarations.

One side effect of this is that you can't just run go run main.go, because you have to list out each file individually. Instead use:

go build && ./qml
go run main.go frontend_view.go frontend_window.go qml_frontend.go keys.go qml_dialog.go

Happy to address any feedback.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.16%) to 62.58% when pulling 6059eaec7a5564e957ac8a5c0a18eb23b200d155 on bawigga:main-decomposition into bb3e751b99d2b29cc8f08e40a98442ca83ad3562 on limetext:master.

bwiggs commented 9 years ago

Also, I'm a bit of a golang newb. So if this isn't very gopher like I understand.

quarnster commented 9 years ago

LGTM, thanks!