Fix for Capital Letter Entry

limetext / lime

Open source API-compatible alternative to the text editor Sublime Text

http://limetext.github.io

BSD 2-Clause "Simplified" License

15.3k stars 1.06k forks source link

Fix for Capital Letter Entry #507

Closed bwiggs closed 9 years ago

bwiggs commented 9 years ago

See #501 for previous discussion and context.

coveralls commented 9 years ago

Coverage increased (+0.02%) to 62.69% when pulling bb9b4b9550a1b00a2f4a10a205fcb90c05b7f626 on bawigga:capital-letter-entry into 0b66ebbabf0bde5204d751fb1222a497fa080c5c on limetext:master.

erbridge commented 9 years ago

LGTM, except for @zoli's comments.

quarnster commented 9 years ago

LGTM, Commenting the logging out is such a half-fix though :) Either remove the line(s) completely or keep the calls in IMO. I don't feel strongly for either, but I'd like to hear @zoli's opinion first in case he strongly wants them enabled before you patch anything up @bawigga.

zoli commented 9 years ago

LGTM, @bawigga I don't feel strongly for either to, Just wanted to know the reason for commenting out and I agree with @quarnster that commenting the logging out is such a half-fix we should remove them if they are cluttering.

bwiggs commented 9 years ago

@zoli @quarnster thanks for the feedback! Those log outputs have been removed.

coveralls commented 9 years ago

Coverage decreased (-0.07%) to 62.6% when pulling 762fb78c1f6be3b883895fbfdd4a3bf8f1aaf3b9 on bawigga:capital-letter-entry into 0b66ebbabf0bde5204d751fb1222a497fa080c5c on limetext:master.

zoli commented 9 years ago

Thanks.