limine-bootloader / limine

Modern, advanced, portable, multiprotocol bootloader and boot manager.
https://limine-bootloader.org
BSD 2-Clause "Simplified" License
1.85k stars 141 forks source link

nix: init flake.nix #339

Closed phip1611 closed 7 months ago

phip1611 commented 7 months ago

TL;DR: This boosts the productivity of all people using NixOS or Nix in general in their environment. It provides you with the right environment to build this project.

This inits a flake.nix into the repository that exports a convenient Nix shell. When using $ nix develop, users will get a shell with all relevant tools to build the repository. If one uses a "direnv" integration into their shell, the environment is automatically loaded.

Not directly #330 but related to it.

phip1611 commented 7 months ago

It will not cause any maintenance burden for you. For example, it is perfectly fine to not update the flake inputs for a year or two. Nix(OS) users however will be very happy about this.

PS: You can ping me from time to time if you need help (assuming that you are not familiar with Nix yet - correct me if I'm wrong)

AshesOfEther commented 7 months ago

GitHub is weird so I ended up marking my review as duplicate, woops :sweat_smile:

mintsuki commented 7 months ago

Hi, thanks for the PR!

I would say I am familiar enough with nix already :p

phip1611 commented 7 months ago

Thanks for merging, nice!