search

liminspace / django-mjml

The simplest way to use MJML in Django templates.
MIT License
260 stars 32 forks source link

Remove DeprecationWarning on default_app_config for django 3.2+ #182

Closed LucasGrugru closed 7 months ago

LucasGrugru commented 1 year ago

I propose a slight change for removing DeprecationWarning.

Django 3.2+ does not need to default_app_config and raise a DeprecationWarning when the app uses it.

liminspace commented 7 months ago

will be added in next release

LucasGrugru commented 7 months ago

@liminspace Why have you deleted this if you will add to the next release ? I do not understand...

liminspace commented 7 months ago

@LucasGrugru it was added in the PR of latest release https://github.com/liminspace/django-mjml/pull/187/files#diff-882c5670b5febde05111a913ef7f15e65ef5b11c03d27fe3833828376b67e09a

LucasGrugru commented 7 months ago

Yes, I understand that you take the work of other contributors without mentioning them. This doesn't really make me want to push further changes.

liminspace commented 7 months ago

@LucasGrugru do you really want to be a contributor by adding one line of code that can be taken of hundred other repos or google search result? in this case all issue creators must be added as well :)

LucasGrugru commented 7 months ago

You have never merged any PR in this or other repos, nothing to do with the number of lines...