search

liminspace / django-mjml

The simplest way to use MJML in Django templates.
MIT License
262 stars 32 forks source link

Simplify docker-compose.yml #95

Closed adnathanail closed 4 years ago

adnathanail commented 4 years ago

I think you can remove some lines (in the first commit) for all use cases of the docker-compose version as the port inside the container doesn't matter outside the container. You just need to bind the container port to a different port outside

If the servers are going to be used from within the docker-compose file you can go a step further and not bind the ports at all as the servers will still be accessible from other services in the same docker-compose file, because the ports were EXPOSE'd in the DockerFile

liminspace commented 4 years ago

@adnathanail This documentation is not for Docker experts. Do you really propose show nothing only because it can work without environments and other options in docker-compose file? I think it's not a good idea and such documentation doesn't make sense because doesn't show how to configure services.