limitbreakinc / creator-token-contracts

MIT License
109 stars 26 forks source link

cant deploy example ERC721CWithBasicRoyalties.sol contract using hardhat #14

Closed SimRunBot closed 5 months ago

SimRunBot commented 5 months ago

Hey there when I try to deploy the ERC721CWithBasicRoyalties using hardhat I get the Error

` // SPDX-License-Identifier: MIT pragma solidity ^0.8.4;

import "../../access/OwnableBasic.sol"; import "../../erc721c/ERC721C.sol"; import "../../programmable-royalties/BasicRoyalties.sol";

/**

I get the Errors:

` TypeError: Function has override specified but does not override anything. --> @limitbreak/creator-token-contracts/contracts/erc721c/ERC721C.sol:25:45: | 25 | uint256 batchSize) internal virtual override { | ^^^^^^^^

TypeError: Function has override specified but does not override anything. --> @limitbreak/creator-token-contracts/contracts/erc721c/ERC721C.sol:39:45: | 39 | uint256 batchSize) internal virtual override { | ^^^^^^^^

TypeError: Function has override specified but does not override anything. --> @limitbreak/creator-token-contracts/contracts/erc721c/ERC721C.sol:64:45: | 64 | uint256 batchSize) internal virtual override { | ^^^^^^^^

TypeError: Function has override specified but does not override anything. --> @limitbreak/creator-token-contracts/contracts/erc721c/ERC721C.sol:78:45: | 78 | uint256 batchSize) internal virtual override { | ^^^^^^^^

TypeError: No arguments passed to the base constructor. Specify the arguments or mark "MyERC721C" as abstract. --> contracts/ERC721C.sol:12:1: 12 contract MyERC721C is OwnableBasic, ERC721C, BasicRoyalties { ^ (Relevant source part starts here and spans across multiple lines). Note: Base constructor parameters: --> @openzeppelin/contracts/access/Ownable.sol:38:16:
38 constructor(address initialOwner) {
^^^^^^^^^^^^^^^^^^^^^^

Error HH600: Compilation failed `

which seems to stem from a missing constructor of the OwnableBasic inheritance.

I am using solidity: "0.8.24", in my hardhat config

SimRunBot commented 5 months ago

okay i just managed to deploy the ERC721C with hardhat using "@openzeppelin/contracts": "^4.8.3" apparently the version 5 brought breaking changes... good to know