Closed CarlKCarlK closed 4 years ago
I have a work around: Manually add all four *.dll directories to one's path: e.g. set path=%path%;M:\Temp\carl\tmp.AVbJkvJefSbgen\bgen-3.0.3\build\Release;C:\Program Files\athr\bin;C:\Program Files\zlib\bin;C:\Program Files\zstd\bin Then the tests will run.
(I found this workaround by downloading the script from curl (I called it JerYI.sh) and then commenting out the "cleanup" code. That left the test*.exe's in the temp directory so I could run them and then I could see the messages about missing zlib.dll, ... bgen.dll.)
Hi Carl, I have just released a new version of this library (4.0.0). It should probably be a release candidate but I can always release 4.0.1, 4.0.2, etc.
I will also write a Development section in the README.md to help further development.
FYI: When I RUN_TESTS under Visual Studio, some pass and some don’t:
1>------ Build started: Project: RUN_TESTS, Configuration: Release x64 ------ 1>Test project D:/OneDrive/programs/bgen 1> Start 1: v12_zlib_layout2 1> 1/16 Test #1: v12_zlib_layout2 .................Exit code 0xc0000135 1>Exception: 0.02 sec 1> Start 2: zero_len_chrom_id 1> 2/16 Test #2: zero_len_chrom_id ................ Passed 0.05 sec 1> Start 3: pbgen_example 1> 3/16 Test #3: pbgen_example .................... Passed 0.03 sec 1> Start 4: metadata_example 1> 4/16 Test #4: metadata_example ................. Passed 0.02 sec 1> Start 5: haplotype 1> 5/16 Test #5: haplotype ........................Exit code 0xc0000135 1>Exception: 0.02 sec 1> Start 6: complex 1> 6/16 Test #6: complex ..........................Exit code 0xc0000135 1>Exception: 0.02 sec 1> Start 7: index 1> 7/16 Test #7: index ............................ Passed 0.04 sec 1> Start 8: open_genotype 1> 8/16 Test #8: open_genotype ....................Exit code 0xc0000135 1>Exception: 0.03 sec 1> Start 9: assert_interface_2 1> 9/16 Test #9: assert_interface_2 ...............Exit code 0xc0000135 1>Exception: 0.02 sec 1> Start 10: assert_interface_3 1>10/16 Test #10: assert_interface_3 ...............Exit code 0xc0000135 1>Exception: 0.02 sec 1> Start 11: assert_interface_3_complex 1>11/16 Test #11: assert_interface_3_complex .......Exit code 0xc0000135 1>***Exception: 0.03 sec 1> Start 12: wrong_bgen_files 1>12/16 Test #12: wrong_bgen_files ................. Passed 0.02 sec 1> Start 13: wrong_metadata_files 1>13/16 Test #13: wrong_metadata_files ............. Passed 0.02 sec 1> Start 14: variant_position_overflow 1>14/16 Test #14: variant_position_overflow ........ Passed 0.03 sec 1> Start 15: one_million 1>15/16 Test #15: one_million ...................... Passed 0.12 sec 1> Start 16: create_metafile 1>16/16 Test #16: create_metafile .................. Passed 0.04 sec 1> 1>56% tests passed, 7 tests failed out of 16 1> 1>Total Test time (real) = 0.66 sec 1> 1>The following tests FAILED: 1> 1 - v12_zlib_layout2 (Exit code 0xc0000135 1>) 1> 5 - haplotype (Exit code 0xc0000135 1>) 1> 6 - complex (Exit code 0xc0000135 1>) 1> 8 - open_genotype (Exit code 0xc0000135 1>) 1> 9 - assert_interface_2 (Exit code 0xc0000135 1>) 1> 10 - assert_interface_3 (Exit code 0xc0000135 1>) 1> 11 - assert_interface_3_complex (Exit code 0xc0000135 1>) 1>Errors while running CTest 1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(149,5): error MSB3073: The command "setlocal 1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(149,5): error MSB3073: "C:\Program Files\CMake\bin\ctest.exe" --force-new-ctest-process -C Release 1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(149,5): error MSB3073: if %errorlevel% neq 0 goto :cmEnd 1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(149,5): error MSB3073: :cmEnd 1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(149,5): error MSB3073: endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone 1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(149,5): error MSB3073: :cmErrorLevel 1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(149,5): error MSB3073: exit /b %1 1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(149,5): error MSB3073: :cmDone 1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(149,5): error MSB3073: if %errorlevel% neq 0 goto :VCEnd 1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(149,5): error MSB3073: :VCEnd" exited with code 8. 1>Done building project "RUN_TESTS.vcxproj" -- FAILED. ========== Build: 0 succeeded, 1 failed, 1 up-to-date, 0 skipped ==========
From: Danilo Horta notifications@github.com Sent: Monday, April 06, 2020 8:40 AM To: limix/bgen bgen@noreply.github.com Cc: Carl Kadie carlk@msn.com; Author author@noreply.github.com Subject: Re: [limix/bgen] On Windows Git Bash, bgen build fails all tests (#9)
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flimix%2Fbgen%2Fissues%2F9%23event-3205978835&data=02%7C01%7C%7C94943182d3794d5c980a08d7da40bdfa%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637217843901926443&sdata=ChgII7lpOSbz3n6xzEp7LEV8O5aNbzm8DBaiUYPVJa4%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABR65P2LRRHS45JAHWULSZDRLHZUJANCNFSM4LURZSRA&data=02%7C01%7C%7C94943182d3794d5c980a08d7da40bdfa%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637217843901936454&sdata=qjnfNK%2F74P9up9iEfQdxjt0EIlwJKcr4WapamvZfBUE%3D&reserved=0.
Have you installed zstd and zlib? It looks like missing library.
Could you try run the tests manually? It will be in some subfolder of your build folder. Here for example:
~/code/bgen/build/test master*
base ❯ pwd
/Users/horta/code/bgen/build/test
~/code/bgen/build/test master*
base ❯ ./test_complex
~/code/bgen/build/test master*
base ❯
It might tell you the exact dll that is missing.
Summary: Yes, it just couldn’t find the DLLs. Fixing that, allows all tests to pass.
Details: Yes, when I ran on the command line it reported the 3 libraries were missing. I tried adding them to my Windows Path (which I thought would work for finding DLL), but it didn’t. So, I instead just copied the 3 DLLs to the release directory. That worked (even from Visual Studio)
1>------ Build started: Project: RUN_TESTS, Configuration: Release x64 ------ 1>Test project D:/OneDrive/programs/bgen 1> Start 1: v12_zlib_layout2 1> 1/16 Test #1: v12_zlib_layout2 ................. Passed 0.65 sec 1> Start 2: zero_len_chrom_id 1> 2/16 Test #2: zero_len_chrom_id ................ Passed 0.01 sec 1> Start 3: pbgen_example 1> 3/16 Test #3: pbgen_example .................... Passed 0.01 sec 1> Start 4: metadata_example 1> 4/16 Test #4: metadata_example ................. Passed 0.01 sec 1> Start 5: haplotype 1> 5/16 Test #5: haplotype ........................ Passed 0.01 sec 1> Start 6: complex 1> 6/16 Test #6: complex .......................... Passed 0.01 sec 1> Start 7: index 1> 7/16 Test #7: index ............................ Passed 0.01 sec 1> Start 8: open_genotype 1> 8/16 Test #8: open_genotype .................... Passed 0.11 sec 1> Start 9: assert_interface_2 1> 9/16 Test #9: assert_interface_2 ............... Passed 0.02 sec 1> Start 10: assert_interface_3 1>10/16 Test #10: assert_interface_3 ............... Passed 0.07 sec 1> Start 11: assert_interface_3_complex 1>11/16 Test #11: assert_interface_3_complex ....... Passed 0.13 sec 1> Start 12: wrong_bgen_files 1>12/16 Test #12: wrong_bgen_files ................. Passed 0.01 sec 1> Start 13: wrong_metadata_files 1>13/16 Test #13: wrong_metadata_files ............. Passed 0.01 sec 1> Start 14: variant_position_overflow 1>14/16 Test #14: variant_position_overflow ........ Passed 0.01 sec 1> Start 15: one_million 1>15/16 Test #15: one_million ...................... Passed 0.02 sec 1> Start 16: create_metafile 1>16/16 Test #16: create_metafile .................. Passed 0.02 sec 1> 1>100% tests passed, 0 tests failed out of 16 1> 1>Total Test time (real) = 1.17 sec ========== Build: 1 succeeded, 0 failed, 1 up-to-date, 0 skipped ==========
From: Danilo Horta notifications@github.com Sent: Monday, April 06, 2020 9:11 AM To: limix/bgen bgen@noreply.github.com Cc: Carl Kadie carlk@msn.com; Author author@noreply.github.com Subject: Re: [limix/bgen] On Windows Git Bash, bgen build fails all tests (#9)
Have you installed zstd and zlib? It looks like missing library.
Could you try run the tests manually? It will be in some subfolder of your build folder. Here for example:
~/code/bgen/build/test master*
base ❯ pwd
/Users/horta/code/bgen/build/test
~/code/bgen/build/test master*
base ❯ ./test_complex
~/code/bgen/build/test master*
base ❯
It might tell you the exact dll that is missing.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flimix%2Fbgen%2Fissues%2F9%23issuecomment-609889539&data=02%7C01%7C%7Cfaf81a9abce242b0ab9b08d7da4528ea%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637217862873101605&sdata=51lRLZ96EP7nq7NAltgLq4RHp2EX6koVyECNEtBniC8%3D&reserved=0, or unsubscribehttps://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABR65P6OZ4SC6YDW2E3P3BDRLH5K5ANCNFSM4LURZSRA&data=02%7C01%7C%7Cfaf81a9abce242b0ab9b08d7da4528ea%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637217862873111605&sdata=7LSI%2F47yue21YauKGALvwxCqT20NGxGOloC9UsHQ690%3D&reserved=0.
I will add the information about DLL in the Development section of README.md I'm writting. Windows DLL does not support RPATH or any way to hard-code the path to dependencies in a library. So the developer is left to do what you just did (copying files around) or adding their path to Windows Path (I think you need to reopen the terminal for it to work).
Here is the log. The internet suggests that xc0000135 might be a missing DLL, but I don't how to learn which one. Thanks!