limjunxian1 / pe

0 stars 0 forks source link

`vendor add` allows to add vendors with the same phone number #6

Open limjunxian1 opened 1 year ago

limjunxian1 commented 1 year ago

Firstly, I added a vendor: vendor add n/Valerie Tan p/91234567 a/12 Buona Vista St. Subsequently, I added another vendor: vendor add n/Jackie Chan p/91234567 and below shows your application rendering the command success

image.png

However, since it is crucial that the user may need to contact the relevant vendors, keying in the wrong phone number is disastrous (consider the case where there are 2 vendors who may have almost the same phone number but just 1 number difference) Clearly, this inconveniences users into reaching out the vendors for their appropriate marriage arrangements and causing hassle to them!

nus-se-bot commented 1 year ago

Team's Response

In the future, we might explore providing warnings if duplicate phone numbers are detected. However, that is NotInScope as we do not foresee many users facing this problem, thus making it lower priority than what has already been implemented. This bug qualifies as NotInScope because the software 'fails' gracefully when duplicate phone numbers are provided, as it adds the vendor without any issues (i.e. no crashes / lags).

Reason for downgrading to Low: We believe this bug fulfils the definition of being "unlikely to affect normal operations", as it is rare that: 1) Two vendors have such similar phone numbers 2) The user happens to mistype the exact number such that it matches another vendor's number

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]