limo-app / limo

A simple Qt based mod manager
GNU General Public License v3.0
119 stars 3 forks source link

File conflicts across multiple deployers not being picked up #20

Closed ZetaDaemon closed 2 months ago

ZetaDaemon commented 2 months ago

Due to my setup with multiple deployers and mods getting split, it seems that limo is not properly picking up conflicts when you open the "Show file conflicts" menu image image as you can see both mods override gd_shields but it says they both are the winner image i assume this is because "ZetaPatch" is only in the CookedPC deployer while "Recharge delay on shields" is originally added to my Borderlands deployer but then split into WillowGame and CookedPC

image also the final order i have where ZetaPatch should override everything else

phen0mX commented 2 months ago

Could you explain why you have multiple deployers pointed at the same directory? I don't quite understand how that makes sense.

limo-app commented 2 months ago

I checked the code and this bug only affects the file conflicts window. The deployer resolves conflicts as it should. The fix for this will be part of the next update on flathub. So to be clear: When you click Deploy, the mod later in the load order will provide this file, as intended.

ZetaDaemon commented 2 months ago

Yes the load order works fine, its only an issue with the conflicts window

ZetaDaemon commented 2 months ago

Could you explain why you have multiple deployers pointed at the same directory? I don't quite understand how that makes sense.

its because of how bl1 modding works, there is no dedicated mods folder, youre just adding and replacing files throughout the game's directory so different mods need to go into different locations and are shipped differently, so its easier to just make multiple deployers to handle mods needing to go into different locations rather than manually repackaging mods to all work in a single deployer

limo-app commented 2 months ago

The file conflicts window has been fixed in 2fb73f7 which is part of 1.0.6.

limo-app commented 2 months ago

Closing since this has been fixed in 1.0.6