[Feature request] Allow use of system provided unrar instead of cloning one into folder during build process

[sjp761]

Would it be possible to use the system version of unrar instead of just cloning it during the build process? I think it will help simplify the build process slightly by reducing the needed steps

[limo-app]

I will look over the CMake file and update it for the non-flatpak build before the next release. This will most likely include adding an option for that case.

[Heisenborgar]

With the recent aa05b0157555d4fa2df7c9a38f2fc13e749edd68 commit. I now get build errors on AUR version of Limo. All is fine, until the final step of the building process. See:

==> Entering fakeroot environment... ==> Starting package()... install: cannot stat 'build/Limo': No such file or directory ==> ERROR: A failure occurred in package(). Aborting... error: failed to build 'limo-git-r60.f5e28e8-1': error: packages failed to build: limo-git-r60.f5e28e8-1

I also have errors with Doxygen, but I just ignore it. Pastebin link here.

[limo-app]

install: cannot stat 'build/Limo': No such file or directory

aa05b01 modified the CMake file with installation rules for Limo after compiling locally. Since it is common practice to use lower case names for executable files, i renamed the output file from Limo to limo. This may cause the issue.

Edit: I fixed the file name.

I will look into doxygen now.

[limo-app]

As for the original issue: aa05b01 also added a CMake option USE_SYSTEM_LIBUNRAR.

[limo-app]

With the recent aa05b01 commit. I now get build errors on AUR version of Limo. All is fine, until the final step of the building process. See:

I never used arch, but it looks like this should be fixed by replacing the line install -Dm 755 -t "${pkgdir}/usr/bin" 'build/Limo' with install -Dm 755 -t "${pkgdir}/usr/bin" 'build/limo' in the PKGBUILD file.

Edit: I fixed the file name.

[limo-app]

Sorry for the mess, i have fixed the executable name for AUR in 14713ec.

[limo-app]

@OdinVex since you are the maintainer for the AUR version, this is just to let you know that the issue should be fixed now.

Sorry again for the dumb change.

[OdinVex]

@OdinVex since you are the maintainer for the AUR version, this is just to let you know that the issue should be fixed now.

Sorry again for the dumb change.

Was "RENAME" in 14713ec required? Also, what issue? I was away from my desk all day until just now.

[Heisenborgar]

Hello @limo-app. Limo now builds just fine, it still errors for Doxygen but I tend to ignore it. However, launching Limo normally doesn't launch anymore. It says:

Launching Limo Failed: Could not find program 'limo'.

Launching it via terminal with Limo works fine tho

[OdinVex]

I pushed a silent update a while ago to adjust it to "limo" for Linux. I'm assuming the .desktop file uses "limo" and is pulled via git when building through AUR. If there's something I missed with it let me know and I'll address in when I wake.

[sjp761]

My feature requested got added so I think I can close this

[OdinVex]

I'll take a look at using system unrar in AUR compilation if defined (when I wake).