search

limosa-io / laravel-scim-server

SCIM 2.0 Server implementation for Laravel
MIT License
50 stars 28 forks source link

Fixes content type header validaton #70

Open juanf opened 4 months ago

juanf commented 4 months ago

Hi, I've noticed that in the tests the content-type header wasn't being validated correctly, this fixes it and adds coverage.

juanf commented 4 months ago

Oh @arietimmerman I see this fails because it returns 404 error instead of 400 The 400 on src/Middleware/SCIMHeaders.php is ignored: throw new SCIMException(sprintf('The content-type header should be set to "%s"', 'application/scim+json'), 400); This PR should fix it https://github.com/limosa-io/laravel-scim-server/pull/68

arietimmerman commented 4 months ago

I've now merged in #68, I guess you'll need to rebase this branch to master to fix the failing pipeline?

juanf commented 4 months ago

Hi @arietimmerman thank you for your work on this package, it's super helpful. Now some tests pass but on those failing this is what I get, I'm not sure why

Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line [11](https://github.com/limosa-io/laravel-scim-server/actions/runs/9402556040/job/25896964640?pr=70#step:5:12):
  - Element 'phpunit', attribute 'backupStaticProperties': The attribute 'backupStaticProperties' is not allowed.
  - Element 'phpunit', attribute 'cacheDirectory': The attribute 'cacheDirectory' is not allowed.
juanf commented 3 months ago

Hi @arietimmerman the pipeline is fixed now.