search

limpkin / mooltipass

Github repository dedicated to the mooltipass project
https://www.themooltipass.com
521 stars 113 forks source link

popup interferes with some websites #126

Closed limpkin closed 10 years ago

limpkin commented 10 years ago

Example: kickstarter...

If it's too hard to be compatible, should we have the extension open by default the new credential set "popup"?

limpkin commented 10 years ago

Note that the bug is slightly different that #127 as the popup is displayed but clicking on any button doesn't change anything

limpkin commented 10 years ago

seems linked to #114

harlequin-tech commented 10 years ago

It's not too hard to do, its just hard to test against thousands of sites. The benefit of the chromeipass method is that its already tested and production quality,

limpkin commented 10 years ago

Is it possible to have the chromeipass credential "popup" open and stay opened until the user makes a choice to replicate our popup behavior?

On Sun, Sep 28, 2014 at 11:24 AM, Harlequin notifications@github.com wrote:

It's not too hard to do, its just hard to test against thousands of sites. The benefit of the chromeipass method is that its already tested and production quality,

— Reply to this email directly or view it on GitHub https://github.com/limpkin/mooltipass/issues/126#issuecomment-57079937.

harlequin-tech commented 10 years ago

http://stackoverflow.com/questions/10479679/how-can-i-open-my-extensions-pop-up-with-javascript chrome dev team has said they will explicitly not enable this functionality

Trying out notifications instead of popups. These are not in-page and do not need to prevent the submit so no css bleed and normal site submit will work.

limpkin commented 10 years ago

notifications are great.... should we not use the popup anymore and close all the bugs? :)

harlequin-tech commented 10 years ago

I'd like to see what the beta test team thinks and how it performs with a greater selection of sites :-)

limpkin commented 10 years ago

fair point :)

On Sun, Sep 28, 2014 at 11:16 PM, Harlequin notifications@github.com wrote:

I'd like to see what the beta test team thinks and how it performs with a greater selection of sites :-)

— Reply to this email directly or view it on GitHub https://github.com/limpkin/mooltipass/issues/126#issuecomment-57100460.