limpkin / mooltipass

Github repository dedicated to the mooltipass project
https://www.themooltipass.com
521 stars 113 forks source link

handle http auth #443

Closed reepush closed 7 years ago

reepush commented 7 years ago

Finally got it working for both Chrome and Firefox!

reepush commented 7 years ago

Force pushed to http-auth branch. Please check the changes.

screen shot 2017-07-06 at 20 57 56

What we need to handle also:

Last two issues relate to the fact that I removed a bunch of code from background/httpauth.js. For my test case everything works and sufficient. But I think I need to put some of the code back to solve last issues. Anyway I need to understand what's needed and what's not and now it's easier to add code step by step.

limpkin commented 7 years ago

it seems to work well... congrats! still waiting to read CI integration tests though