Closed reepush closed 7 years ago
@reepush : it seems you didn't read @mosaadm who mentioned that there's nothing to put in CI fails! we need to talk as soon as possible.
@mosaadm I checked lcdc.ch again, I have adblock installed that's why that link button didn't show up for me. Thanks for the feedback. Now it's fixed. I can move this test to supported after you test and approve it. Will it work this way?
@mosaadm
And with techmania.ch I get a strange behaviour – it works manually, but in automated test onSubmit handler isn't triggered. It can be caused by our "syntetic events", especially because it's <a>
element and it's behave a bit different as I discovered today. I will try to submit form by simulating pressing return key on password field, maybe it will work out.
@reepush didn't we agree that we actually can't simulate return key press in the password field?
@reepush techmania.ch does NOT work manually
Walked through all tests in NotSupported again:
ldlc.ch (problem with ad)
techmania.ch (problem with link as anchor)
evernote.com (problem with two-step auth)
tripadvisor.com (problem with fields detection)
pc-ostschweiz.ch (problem with onSubmit event)
kenwoodworld.com (problem with submit button detection)
workbench.cisecurity.org (problem with submit button detection)
trillian.im (problem with constant requests as @limpkin said, not fixed)
minfin.com.ua (problem with captcha detection)
microchipdirect.com (problem with submit button detection)
airbnb.com (problem with text input)
@limpkin
this is starting to be a lot of hardcoded website support, which I don't like
Agree. I would like to do two things in this PR:
@reepush
@limpkin
can't we intercept both, have submit event catching as a backup?
sure, same way how doSubmit
currently works with triggering submit event
@limpkin Haven't figured out problem with airbnb.com and React way of handling input's value. Everything else works and ready for review.
@reepush ok! what's the link to your travis?
@limpkin Travis build. Not sure about gmail though.
might be worth updating the documentation of mccombinations!
@limpkin I have updated mcCombinations.md
@reepush , from @mosaadm :
i confirm once again that for me techmania doesn't work manually.
moved tests which fail in CI but pass manually to CIFails suite, so we can better distinguish which tests need attention