limpkin / mooltipass

Github repository dedicated to the mooltipass project
https://www.themooltipass.com
521 stars 113 forks source link

sites compatibility #469

Closed reepush closed 7 years ago

reepush commented 7 years ago

moved tests which fail in CI but pass manually to CIFails suite, so we can better distinguish which tests need attention

limpkin commented 7 years ago

@reepush : it seems you didn't read @mosaadm who mentioned that there's nothing to put in CI fails! we need to talk as soon as possible.

reepush commented 7 years ago

@mosaadm I checked lcdc.ch again, I have adblock installed that's why that link button didn't show up for me. Thanks for the feedback. Now it's fixed. I can move this test to supported after you test and approve it. Will it work this way?

reepush commented 7 years ago

@mosaadm
And with techmania.ch I get a strange behaviour – it works manually, but in automated test onSubmit handler isn't triggered. It can be caused by our "syntetic events", especially because it's <a> element and it's behave a bit different as I discovered today. I will try to submit form by simulating pressing return key on password field, maybe it will work out.

limpkin commented 7 years ago

@reepush didn't we agree that we actually can't simulate return key press in the password field?

limpkin commented 7 years ago

@reepush techmania.ch does NOT work manually

reepush commented 7 years ago

Walked through all tests in NotSupported again:

ldlc.ch (problem with ad)

techmania.ch (problem with link as anchor)

evernote.com (problem with two-step auth)

tripadvisor.com (problem with fields detection)

pc-ostschweiz.ch (problem with onSubmit event)

kenwoodworld.com (problem with submit button detection)

workbench.cisecurity.org (problem with submit button detection)

trillian.im (problem with constant requests as @limpkin said, not fixed)

minfin.com.ua (problem with captcha detection)

microchipdirect.com (problem with submit button detection)

airbnb.com (problem with text input)

reepush commented 7 years ago

Techmania screen recording

@limpkin

this is starting to be a lot of hardcoded website support, which I don't like

Agree. I would like to do two things in this PR:

  1. Move from handling submit event to handling click event on submit button and keypress event on password field. This way I can delete all these edge cases.
  2. Improve how current submit button detection works – prioritize detected buttons base on how close they are from input fields. It will solve many potential problems in the future.
limpkin commented 7 years ago

@reepush

  1. can't we intercept both, have submit event catching as a backup?
  2. that makes sense
reepush commented 7 years ago

@limpkin

can't we intercept both, have submit event catching as a backup?

sure, same way how doSubmit currently works with triggering submit event

reepush commented 7 years ago

@limpkin Haven't figured out problem with airbnb.com and React way of handling input's value. Everything else works and ready for review.

limpkin commented 7 years ago

@reepush ok! what's the link to your travis?

reepush commented 7 years ago

@limpkin Travis build. Not sure about gmail though.

limpkin commented 7 years ago

might be worth updating the documentation of mccombinations!

reepush commented 7 years ago

@limpkin I have updated mcCombinations.md

limpkin commented 7 years ago

@reepush , from @mosaadm :

limpkin commented 7 years ago

i confirm once again that for me techmania doesn't work manually.