limpkin / mooltipass

Github repository dedicated to the mooltipass project
https://www.themooltipass.com
521 stars 113 forks source link

pass mozilla validation #498

Closed reepush closed 7 years ago

reepush commented 7 years ago

I have removed contentSettings permission. It's valid in Chrome, but we don't use this API anyway. For jQuery it seems to be a mistake with hash on testers side, I got exactly the same checksum that supposed to be valid:

➜  chrome_extension git:(master) shasum -a 256 vendor/jquery-3.2.1.js
0d9027289ffa5d9f6c8b4e0782bb31bbff2cef5ee3708ccbcb7a22df9128bb21  vendor/jquery-3.2.1.js
limpkin commented 7 years ago

that's odd... i have the very same hash as mozilla...

limpkin commented 7 years ago

turns out it's a lr/lf problem.