Insufficient restrictions of dorm tag

[limrik]

Dorm tags have the restriction of any non-empty strings, but this does not seem to be sufficient as I can add dates that are not relevant to the dorm at all, perhaps use a enum with more specific available dorm tags?

[nus-pe-script]

Team's Response

Thanks for bringing this up! According to the information on the course website, "It is better to warn rather than to block when inputs are not compliant with the expected format, unless accepting such inputs can hinder the operations of the software.".

Our application allows for certain flexibility and hence does not have any restriction on the dorm that a user can store, as long as it won't hinder the operation of the software.

Furthermore, regarding the suggestion "perhaps use an enum with more specific available dorm tags," it builds on the assumption that we have a list of every possible dorm in the world (as there is no feature that only fits in the NUS context, Dormie could potentially be adapted by any institution). There is a certain difficulty in retrieving such a list, and hence we claim that it is out of scope.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

• [x] I disagree

Reason for disagreement: Hi, thank you for your response.

I do believe that a warning message would suffice (which in your case is also not provided), but perhaps it would be better to scope your application to a smaller scope so that your features are better able to fit the scope, instead of allowing no constraints and saying that your scope is all dormitories. In this case a dorm tag of "$$$$" would also be accepted which does not make sense.

---