search

lin-bus / linux-lin

Linux kernel LIN bus support implemented as TTY line discipline for generic UART conrollers, documentation https://github.com/lin-bus/linux-lin/wiki, based on https://github.com/lin-bus/linux-lin/wiki/sllin-rtlws14-paper.pdf, more CAN related projects http://canbus.pages.fel.cvut.cz/
https://github.com/lin-bus/linux-lin/wiki
38 stars 26 forks source link

Kernel 5 - Preliminary 3 #7

Closed kbader94 closed 2 years ago

kbader94 commented 2 years ago

Sorry I keep polluting the PRs lol. These should be the only changes required for newer kernel support. I haven't done any extensive testing but it works with kernel 5.10.17

ppisa commented 2 years ago

//changed in version 4.11.

Please, no C++ comments for now (or did kernel coding style changed???) Keep comments lines length under 100 chars. When multiline, check coding style

/*
 * uuu
 * uuu
 * /

https://www.kernel.org/doc/Documentation/process/coding-style.rst

The preferred style for long (multi-line) comments is:

ppisa commented 2 years ago

Please, start sllin kernel driver part commits by sllin: prefix and add Signed-off-by: to keep kernel practice. In general, longer comments for reason for commit are better to document in commit message (including the links to related docs) than in code.

Generally I agree with changes. Please, update them and I can merge the pull or you can push directly when formatting/comments etc are resolved.

kbader94 commented 2 years ago

@ppisa Thanks for the advice, I'm not super familiar with kernel coding styles and standards, as I'm sure you can tell so I appreciate the guidance there. I'll brush up on the style guidelines and fix those formatting issues tonight. If it's OK with you I'll probably submit it for another review just to make sure it's consistent with the kernel coding styles guidelines which you have a better eye for :P. I like to consider myself capable but I definitely don't mind having my work reviewed by someone more experienced, especially in terms of best practices for kernel work. Thanks again for the guidance!