search

lin-ycv / EverythingPowerToys

Everything search plugin for PowerToys Run
Eclipse Public License 2.0
2.14k stars 56 forks source link

🐛 Crashes with 0.80 #105

Open AJolly opened 3 months ago

AJolly commented 3 months ago

I get frequent crashes with 0.8 that I do not with 0.78

Logs (please upload or provide link to you log):

2024-05-18.txt

Version:

AJolly commented 3 months ago

I take that back, I do get them with 0.80 as well.

lin-ycv commented 3 months ago

does this happen with specific files/directory? have you notice if a certain search query causes the issue? Does it crash when searching with Everything instead of this plugin?

My best guess would be is whatever you're searching for is deeply nested, and the path is over 260 characters.

Error from log

[2024-05-18 14:15:06.0089] [ERROR] [C:\Users\Lin\Documents\repos\PowerToys\src\modules\launcher\Plugins\EverythingPowerToys\Main.cs::163] -------------------------- Begin exception -------------------------- Message: Everything Exception

Exception full name : System.ArgumentException Exception message : title cannot be null or empty (Parameter 'title') Exception stack trace: at Community.PowerToys.Run.Plugin.Everything.Everything.Query(String query, Settings setting)+MoveNext() at System.Collections.Generic.List1.AddRange(IEnumerable1 collection) at Community.PowerToys.Run.Plugin.Everything.Main.Query(Query query, Boolean delayedExecution) Exception source : Community.PowerToys.Run.Plugin.Everything Exception target site: Boolean MoveNext() Exception HResult : -2147024809 -------------------------- End exception --------------------------

The error points to this https://github.com/lin-ycv/EverythingPowerToys/blob/3d743f1f061c19324b2e1beaa5f63b5a2de4c6fe/Main.cs#L172 Which is most likely caused by something here https://github.com/lin-ycv/EverythingPowerToys/blob/3d743f1f061c19324b2e1beaa5f63b5a2de4c6fe/Everything.cs#L67-L77

AJolly commented 3 months ago

Given how frequently i see that error, im not sure im searching for anything long. Is there a debug mode I can run it in to log?

lin-ycv commented 3 months ago

Is there a debug mode I can run it in to log?

Try the new version, if it still crashes, use the debug dll and upload the log that's saved on the desktop

qianzyGit commented 2 months ago

It seems like I have the same issue too. Even after updating to version 81, it still causes the powertoy

lin-ycv commented 2 months ago

Please turn on debug option in 81 and provide the desktop logs.

lin-ycv commented 2 months ago

@AJolly @qianzyGit can you provide desktop logs after setting the debug option in settings to verbose?

qianzyGit commented 2 months ago

EverythingPT.log

lin-ycv commented 1 month ago

@AJolly @qianzyGit Please test v0.82.0

qianzyGit commented 1 month ago

@AJolly @qianzyGit Please test v0.82.0

It still crashed [Uploading PowerToysReport_2024-07-05-13-30-09.zip…]()

EverythingPT.log

lin-ycv commented 1 month ago

@qianzyGit can you provide the log from %localappdata%\Microsoft\PowerToys\PowerToys Run\Logs\0.82.0.0 Other than you being unable to get a response from github, I don't see any meaningful errors from your `EverythingPT.log, it's happening somewhere I'm not logging (or it's straight up crashing everything).

Sidenote: maybe try disabling the update feature I don't think it's the issue, but worth a try?

When it crash, does Powertoys run still work? or does the whole thing crash?

qianzyGit commented 1 month ago

2024-07-04.txt 2024-07-05.txt When it crashes, powertoys won't work.

lin-ycv commented 1 month ago

2024-07-04.txt 2024-07-05.txt When it crashes, powertoys won't work.

I see some errors and exceptions, but based on these logs, I don't see anything that's related to EPT... can you disable all plugins other than EPT to make sure the crash is from EPT and not something else?