search

lin-ycv / EverythingPowerToys

Everything search plugin for PowerToys Run
Eclipse Public License 2.0
2.2k stars 57 forks source link

[BUG] Self-Extraction Installer install fails #93

Closed xixiha5230 closed 5 months ago

xixiha5230 commented 5 months ago

Describe the bug

Show error opening file for writing when installing.

To Reproduce Steps to reproduce the behavior:

  1. Double click exe file
  2. Click install

Expected behavior Installing normally

Screenshots image

Logs (please upload or provide link to you log): No logs generated

Version (please provide the version of software you are using):

Additional context Maybe it's because there is a space between my username

lin-ycv commented 5 months ago

this is the same issue as #90 previous versions of the installer automatically closes powertoys, but that behaviour gets caught by AV as malicous, so for this version I dropped that logic, meaning you have to close PowerToys manually before the install.

xixiha5230 commented 5 months ago

I have an idea - if the user is detected to not have closed PowerToy, a pop-up prompt could be displayed to remind the user to close it. This could help avoid AV issues and not make the user think an error has occurred.

I understand this may add some work, but it's just a small suggestion. How to handle it is entirely up to you. Thank you for developing this useful plugin.

lin-ycv commented 5 months ago

Trying to deal with AV FP is complex, as each have their own logic, and can also change their detection triggers from time to time. Some AV will flag the act of process scaning as malicious while others won't.

I agree that it's not very well handled right now, I still need to do more tests to figure out the best way forward. Hopefuly this can be dealt with before the next release.