search

lin2k / pdfium

Automatically exported from code.google.com/p/pdfium
0 stars 0 forks source link

CFX_ByteString::LockBuffer() and CFX_WideString::LockBuffer() add complexity and are nearly unused. #144

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
These string types implement ref-counted shared buffers with COW semantics. The 
lock calls set the refcnt to -1, indicating permanent private ownership, which 
then must be tested in lots of places.

CFX_ByteString::LockBuffer is unused.
CFX_WideString::LockBuffer is called in but one place, prior to a string 
replace.

Original issue reported on code.google.com by tsepez@chromium.org on 24 Apr 2015 at 5:01

GoogleCodeExporter commented 9 years ago 
https://pdfium.googlesource.com/pdfium//+/4fc0d991a47ba92c1d8657b326d2752951ca79
1a

Original comment by tsepez@chromium.org on 28 Apr 2015 at 9:36