lina-usc / pylossless

🧠 EEG Processing pipeline that annotates continuous data
https://pylossless.readthedocs.io/en/latest/
MIT License
18 stars 8 forks source link

Handle slider syncing at pylossless app level (`qcgui` module) #61

Closed scott-huberty closed 1 year ago

scott-huberty commented 1 year ago

mea culpa on the current design where we made the mne_visualizer module handle slider sharing/syncing between different instances of the class.

https://github.com/lina-usc/pylossless/blob/4c3ae7108da82a1985f4548394d472dbbfb7db37/pylossless/dash/mne_visualizer.py#L282-L291

It's very simple to create a callback at the app level (i.e. in our case, qcgui), that links the sliders.

This would really simplify mne_visualizer, (especially its callback) which we want to split off into its own project at some point, because then in any given instance of MNEVIsualizer, a channel/time slider would only ever be an input for it's own graph.

I'll open a PR.