lina-usc / pylossless

🧠 EEG Processing pipeline that annotates continuous data
https://pylossless.readthedocs.io/en/latest/
MIT License
24 stars 8 forks source link

Enforce flake8, codespell, pydocstyle in pylossless.dash module #66

Closed scott-huberty closed 1 year ago

scott-huberty commented 1 year ago

Next up on our journey towards PEP8 / Numpydoc compliance.

These ones might be a doozy.

Andesha commented 1 year ago

I'll likely get to this soon, so don't start it yourself :wink:

scott-huberty commented 1 year ago

Have fun!!!! 😉

Andesha commented 1 year ago

What's the codespell thing you use?

scott-huberty commented 1 year ago

https://pypi.org/project/codespell/

in the terminal: codespell . or for example codespell pylossless/dash/qcgui.py

Andesha commented 1 year ago

thanks!

scott-huberty commented 1 year ago

@Andesha let me know if you want me to merge #62 now or after your done.

There is a decent chance that there will be some conflicts that need to be resolved if you've already started the linting work.

I am fine with handling conflicts in #62 if needed.

Andesha commented 1 year ago

Probably best to wait to merge it because there's a few classes that I won't touch for now as they have problems like "too many instance variables"

I'll probably be done in a little bit

scott-huberty commented 1 year ago

Ok i'll wait to merge it until we have your PR merged.

"too many instance variables"

interesting... never heard of this one.

Andesha commented 1 year ago

image

scott-huberty commented 1 year ago

@Andesha what linter are you using?

EDIT: ah, i see, pylint.

FWIW we use flake8 and I don't think it raises these flakes (nor does it raise the too many lines in file flake).

Andesha commented 1 year ago

Odd... now that you mention it I was trying to use flake8... :thinking:

Andesha commented 1 year ago

good thing you noticed that - I had conflicting linting tools going and it was causing huge issues...

its been fixed now and is also showing way less problems so I should be done shortly(-ish)

scott-huberty commented 1 year ago

awesome!

Andesha commented 1 year ago

can prolly close this now due to #76