search

lina-usc / pylossless

🧠 EEG Processing pipeline that annotates continuous data
https://pylossless.readthedocs.io/en/latest/
MIT License
18 stars 8 forks source link

Fix first pass of linting errors #76

Closed Andesha closed 1 year ago

Andesha commented 1 year ago

As per #66 .

I've decided to wait on fixing some of the larger blocks of linting errors until everything is back into main.

It's more than likely that those will take some larger structural changes so best to get stable first.

scott-huberty commented 1 year ago

got it.. so in that case @Andesha I will merge #61 and we can handle any conflicts here (if they pop up).

Andesha commented 1 year ago

yeah, that's for the best

I should also work on testing the QC for myself so that I can make sure I am not breaking things

scott-huberty commented 1 year ago

I'll pull your branch and test it as well.

scott-huberty commented 1 year ago

I'm looking at the conflicts now.

scott-huberty commented 1 year ago

I Fixed the conflicts and launched the dashboard locally. Everything appears to work fine!

Andesha commented 1 year ago

I'm still having a couple of issues with the dashboard but I pulled in your changes and did another wave of linting.

Only thing left is the mne_visualizer.py file, which I'm going to leave alone for a bit as I think it needs less nesting after the next set of bug fixes...

Andesha commented 1 year ago

Just pushed another wave of fixes - should be good to go

scott-huberty commented 1 year ago

LGTM.

Just pushed an empty commit so we can verify that CI's pass.

Maintenance note: flake8 linting is passing in the dash module, some docstring formatting still needed for Numpy doc compliance, will circle back on follow up PR.

Andesha commented 1 year ago

I forgot to run codespell and the numpy doc string stuff sorry :clown_face:

scott-huberty commented 1 year ago

I forgot to run codespell and the numpy doc string stuff sorry 🤡

All good! linting that module was enough work ha.