FIX: select folder callback error on mac

lina-usc / pylossless

🧠 EEG Processing pipeline that annotates continuous data

https://pylossless.readthedocs.io/en/latest/

MIT License

18 stars 8 forks source link

FIX: select folder callback error on mac #84

Closed scott-huberty closed 1 year ago

scott-huberty commented 1 year ago

Fixes #29

This works on my mac. Fixes the error we were getting by using the multiprocessing module to ~~keep the process in the main thread~~ execute this action in a separate process.

[x] I'll test this out on my windows computer tomorrow morning. (UPDATE: Works).

@christian-oreilly Can you review/pull this branch and test it out on your side? (NOTE: this branch is on the lina-usc remote, NOT my fork.)

christian-oreilly commented 1 year ago

Folder loading works fine on my side too! On a side note (not for this PR), we should probably gracefully fail (e.g., pop up a message windows mentioning that this loaded path is not a BIDS project, or a LL output...) on a call to self.pipeline.load_ll_derivative(self.fpath) that does not have all the expected bits of info. For now, it just crash with the usual way when a Dash app crash.

scott-huberty commented 1 year ago

Folder loading works fine on my side too!

Awesome!!! and agreed, that is a good idea.

scott-huberty commented 1 year ago

@Andesha would you mind pulling this branch and trying out the select folder button, on your Linux computer?

Andesha commented 1 year ago

can confirm this works for me

scott-huberty commented 1 year ago

awesome! I am going to rebase with main and merge.