As discussed in the pymat lossless dev meeting, flag_outlier_chs should occur inside the rereference function, to exclude "comically" bad channesl without marking them.
Also, since the first step of flag_outlier_chs should be to take the std across time (not epochs)s, it is not clear to me whether flag_outlier_chs is doing anything different than flag_ch_sd_ch (besides not flagging the bad channels)?
@christian-oreilly @jadesjardins
If so, maybe we can just re-use flag_ch_sd_ch and add a kwarg to the function call to add the outlying channels to flagged_chs (which we would set to False when used inside the rereference func).
As discussed in the pymat lossless dev meeting,
flag_outlier_chs
should occur inside therereference
function, to exclude "comically" bad channesl without marking them.Also, since the first step of
flag_outlier_chs
should be to take thestd
across time (not epochs)s, it is not clear to me whetherflag_outlier_chs
is doing anything different thanflag_ch_sd_ch
(besides not flagging the bad channels)? @christian-oreilly @jadesjardinsIf so, maybe we can just re-use
flag_ch_sd_ch
and add a kwarg to the function call to add the outlying channels toflagged_chs
(which we would set toFalse
when used inside therereference
func).