ENH, FIX: Moved flag_outlier_chs and added fixed_threshold method.

lina-usc / pylossless

🧠 EEG Processing pipeline that annotates continuous data

https://pylossless.readthedocs.io/en/latest/

MIT License

18 stars 8 forks source link

ENH, FIX: Moved flag_outlier_chs and added fixed_threshold method. #92

Closed scott-huberty closed 1 year ago

scott-huberty commented 1 year ago

Closes #55 Closes #56 Closes #88 Closes #91 Closes #95 Closes #96

Work from dev session on april 7th.

Maybe wait to merge this until after the (hopeful) pymat dev session on tuesday the 11th

NOTE, STILL TODO:

[x] update pytest to reflect updated pipeline methods

scott-huberty commented 1 year ago

@christian-oreilly This is from our last programming session (where we moved the find_outliers method) and added fixed threshold option (for replication with lossless paper.).

I've also updated _get_outliers_quantile (per our tukey test discussion) and updated the testing suite. It would be nice to merge this soon. Let me know if you would like to review. I've left comments to point you in the direction of the most important changes.

christian-oreilly commented 1 year ago

I can try to go through it on Tuesday if that is ok with you.

scott-huberty commented 1 year ago

Just a note that I likely won't return to pylossless until I'm in SC anyways so if you want to wait until I'm there that's fine with me.