search

lina-usc / pylossless

🧠 EEG Processing pipeline that annotates continuous data
https://pylossless.readthedocs.io/en/latest/
MIT License
18 stars 8 forks source link

The colab example is not accessible anymore #93

Closed christian-oreilly closed 1 year ago

christian-oreilly commented 1 year ago

In previous versions, the colab notebook example was accessible through the readme of the GitHub repo. With the previous refactoring, this bit has been removed from the readme without being added back anywhere else in the doc.

scott-huberty commented 1 year ago

In previous versions, the colab notebook example was accessible through the readme of the GitHub repo. With the previous refactoring, this bit has been removed from the readme without being added back anywhere else in the doc.

Feel free to put it in the README.

christian-oreilly commented 1 year ago

Yes. That is a possibility. But we may want to consider alternatives before I do so (e.g., having a section of our doc for notebooks). I am not so sure about it.

scott-huberty commented 1 year ago

having a section of our doc for notebooks

Sure, definitely.

FYI I did link to the notebook here.

But I need to rename that example - I haven't had the time to substantially work on the doc lately. I'll get to it after we finish the development for .01

christian-oreilly commented 1 year ago

FYI I did link to the notebook here.

This is not the Colab example. I won't run on the Colab.

scott-huberty commented 1 year ago

FYI I did link to the notebook here.

This is not the Colab example. I won't run on the Colab.

There is a link to the collab notebook.

"This can even be done on a virtualized platform, like Google Colab! To try it, you can run this notebook from here!."

christian-oreilly commented 1 year ago

Oh, right, apologies, I did not see the link!

christian-oreilly commented 1 year ago

The link is available. The discussion on a section for notebooks is not pressing, so I scheduled it for the 0.02 release.

scott-huberty commented 1 year ago

BTW - the last time I ran the jupyter notebook example (after we merged the annotation refactoring) it was really slow. The next time you run it Let me know if it is unusually slow for you too.