linagora / Twake-Mobile

Twake mobile application
GNU Affero General Public License v3.0
58 stars 27 forks source link

[Story] Upload file in the chat #1137

Closed BenoitTallandier closed 1 year ago

BenoitTallandier commented 2 years ago

User story summary

Definition
Business case
Criteria
UI/UX Design
Notes
Related

Definition

Given I am a user
When I look to send an image in the chat from my gallery
Then I click on the paperclip icon 
And I click on "Photo or Video" to see my entire gallery
And I select images that I want to send
And I click  send on "add"
And images are in the input and I can add a message
And I send the message
Given I am a user
When I look to take a picture and send it to a channel
Then I click on the paperclip icon 
And I click on "Take a picture" to open my gallery
And I take the picture
And I click  send on "add"
And the image is in the input and I can add a message
And I send the message
Given I am a user
When I look to send a folder in the chat
Then I click on the paperclip icon 
And I click on "File" to see my files
And I select files that I want to send
And I click  send on "add"
And files are in the input and I can add a message
And I send the message
Given I am a user
When I look to send an attachment (file, image, or take a photo)
And I didn't give the right to Twake to do it
And I click on "take a picture", "Photo or video" or "file", 
Then the popup system appears saying to give access to the application
In the background of Twake, Twake popup appears to say that I have to give the right.
In this popup, I can click on cancel (to close the popup) or allow (that will open the system popup again).

Business case

Flow

FLOW

Criteria (Test case)

UI UX Design

Design : https://www.figma.com/file/uLw3iWnOEGaRlJnfPz4Pv0/Twake.new?node-id=604%3A49280

Notes

Related

huynguyennovem commented 2 years ago

@BenoitTallandier, I have some questions here, pls help to answer:

  1. Is user able to send a message which contains an uploading file?
  2. Do we limit the number of file on a message?
  3. As I see the new design here, there will be a separated screen for file uploading, right? If it does, it will conflict with your mockup on some screens. Pls help to make this to be consistent.
BenoitTallandier commented 2 years ago

Hi @huynguyennovem

  1. We updated the design : File will be uploaded when the message is sent.
  2. 10 files
  3. Design updated :)
huynguyennovem commented 2 years ago

Hi @huynguyennovem

  1. We updated the design : File will be uploaded when the message is sent.
  2. 10 files
  3. Design updated :)

Hi @BenoitTallandier, I would like to confirm again the first one.

  1. As the design here: File Upload Flow (https://zpl.io/V1LrBkk): All files will be uploaded before user sends a message. So there is two steps here:
    • Step 1: Upload files (success -> add to list; fail -> error shown)
    • Step 2: Send message (with uploaded files)

Am I right about the upload flow?

huynguyennovem commented 2 years ago

Hi @BastiaanVanGaalen

  1. About file uploading by this design: file-attachment-flow-4 (https://zpl.io/bP3o4jx) and Benoit's description here: "I can stop the upload of the file by clicking on the cross during the upload"

    I don't see UI for the case file is uploading (to see the cross icon for cancelling), can you add the design for this?

  2. About file uploading by this design: file-attachment-flow-4 (https://zpl.io/bP3o4jx): Benoit has confirmed that these is 10 files maximum, not 20 files. Pls help to update this to the design.

  3. About photo uploading by this design: photo-attachment-flow-2 (https://zpl.io/2j3nnO4): As my understanding, the preview image will be show after capturing by camera, then user can choose which one will be uploaded. Am I right? If so, what is the photo-attachment-flow-3 (https://zpl.io/254DD5r)?

BenoitTallandier commented 2 years ago

Hi @huynguyennovem

  1. We updated the design : File will be uploaded when the message is sent.
  2. 10 files
  3. Design updated :)

Hi @BenoitTallandier, I would like to confirm again the first one.

  1. As the design here: File Upload Flow (https://zpl.io/V1LrBkk): All files will be uploaded before user sends a message. So there is two steps here:
  • Step 1: Upload files (success -> add to list; fail -> error shown)
  • Step 2: Send message (with uploaded files)

Am I right about the upload flow?

Hi @huynguyennovem No, files are uploaded after your sent the message :

huynguyennovem commented 2 years ago

Hi @BenoitTallandier,

If there is a long file list, the user will get a sequence error messages in case they are all failed uploading for eg. So I don't think it's good for user, IMO.

I think you may misunderstood the "attached", "uploaded" and "sent" here. In fact, they will behave like this when combined with APIs:

So as far as I can see the current design is more suitable for APIs than what you describe.

BenoitTallandier commented 2 years ago

About photo uploading by this design: photo-attachment-flow-2 (https://zpl.io/2j3nnO4): As my understanding, the preview image will be show after capturing by camera, then user can choose which one will be uploaded. Am I right? If so, what is the photo-attachment-flow-3 (https://zpl.io/254DD5r)?

  1. I described the flow for uploading photo in the US :)
BenoitTallandier commented 2 years ago

If there is a long file list, the user will get a sequence error messages in case they are all failed uploading for eg. So I don't think it's good for user, IMO.

I doubled check, you're right about that. Let's upload files or images inside this popup : https://app.zeplin.io/project/5fd7afb0317dc8827d6a8fb5/screen/61b30b34db859f49de1af3a4.

huynguyennovem commented 2 years ago

About photo uploading by this design: photo-attachment-flow-2 (https://zpl.io/2j3nnO4): As my understanding, the preview image will be show after capturing by camera, then user can choose which one will be uploaded. Am I right? If so, what is the photo-attachment-flow-3 (https://zpl.io/254DD5r)?

  1. I described the flow for uploading photo in the US :)

I double check US but I still don't see the desc about this. I think the photo-attachment-flow-2 is enough to understand what needs to be done. If not, what are the conditions to have photo-attachment-flow-3?

I assume that after the user selected some pictures taken in photo-attachment-flow-2, photo-attachment-flow-3 will be displayed. So what if user want to take more pictures?

BenoitTallandier commented 2 years ago

I double check US but I still don't see the desc about this. I think the photo-attachment-flow-2 is enough to understand what needs to be done. If not, what are the conditions to have photo-attachment-flow-3?

Forget the photo-attachment-flow-3 for now. The flow is photo-attachment-flow-2 > photo-attachment-flow-4

huynguyennovem commented 2 years ago

Hi @BenoitTallandier, after thinking again, I propose the flow like this. What do you think?

idea

For more detail:

And if user click on File, it will lead to photo-attachment-flow-4 screen as we understood. But there will be no captured/chosen pics. I got inspiration from referencing some similar apps.

p/s: sorry my mockup is not beautiful :)

BenoitTallandier commented 2 years ago

Thank you to share your ideas! 🙏

  1. We choose to not implement the media (A,B,C, ...) option in order to save time. Is it long for you to implement this bare ?
  2. I may not be enough clear on this "File" button. If we want to share an image, "photo or video" is a very good shortcut because we land directly inside the gallery (photo-attachment-flow-4). However, if we want to share a file stored the phone (and not the gallery), we need an other button driving to the file folder (in iOS, it's iCloud by default for example). So we need this button leading in the file-attachment-flow-3

IMO, if it's easy to build the 1, let's do it!! 🔥
For the 2, we need to follow the user story on that. :-)

BenoitTallandier commented 2 years ago

@huynguyennovem I updated the FLOW. Are we aligned with that? If yes, I'll ask Dmitry to update the design

huynguyennovem commented 2 years ago

@huynguyennovem I updated the FLOW. Are we aligned with that? If yes, I'll ask Dmitry to update the design

I agree with that. Very clear flow. Thanks!

BenoitTallandier commented 2 years ago

New design

https://www.figma.com/file/uLw3iWnOEGaRlJnfPz4Pv0/Twake.new?node-id=604%3A49280

Business case