linagora / Twake

Twake is a secure open source collaboration platform to improve organizational productivity.
https://twake.app
GNU Affero General Public License v3.0
1.79k stars 194 forks source link

Notification > A push notification for a direct group doesn't display the members name #1293

Open tlle14 opened 3 years ago

tlle14 commented 3 years ago

Precondition

Refer to https://github.com/Twake/Twake/issues/489

Actual Result

When sending a message to the direct group, it pushes a notification. The push notification only displays: <author> in <Workspace_name>, the user doesn't know exactly which channel has the message. IMG_2079

Expected Result

Please refer to the story then work with our UX designer for the final result.

Environment

Both iOS and Android App Build version: 2.2.9

bmuddha commented 3 years ago

@RomaricMourgues Hello, Any ideas about this issue, as far as I know direct chats do not have any name, they have dynamic names composed from chat member names, of which there could be many.

RomaricMourgues commented 3 years ago

Exactly, and you can get the users information with this API:

POST /ajax/users/all/get

{
    id: ["uuid", "uuid", "uuid", "uuid", "uuid"]
}
bmuddha commented 3 years ago

Yeah that's cool, but we don't need to get users information, @tlle14 is talking about the issue with channel name in notification title, can we dynamically generate channel name for directs (and add it to notification title), before sending the notification or does it require too much hassle, so that we can postpone this issue for better times?

tlle14 commented 3 years ago

Hi @bobs4462 , that's why it's a minor ticket, we should fix later

RomaricMourgues commented 3 years ago

Oh sorry I did not understood. It is a Twake issue, currently the format is:

Author in Company for direct channels

ChannelName in Company • Workspace for workspace channels

You want something like Author1, Author2, Author3 in Company ?

bmuddha commented 3 years ago

I'm not really sure what I want). Maybe we can add Something like Author1, Author2... but only first 20 symbols or so, so that it won't become messy

tlle14 commented 3 years ago

Oh sorry I did not understood. It is a Twake issue, currently the format is:

Author in Company for direct channels

ChannelName in Company • Workspace for workspace channels

You want something like Author1, Author2, Author3 in Company ?

Hi @RomaricMourgues , the issue is about how we display a notification for a direct group Example: the direct group has: member1, member2, member3, member4 When member1 sending a message to the group, how the notification will display?

RomaricMourgues commented 3 years ago

For now if I remember it will display just "Sender in Company" as title. We'll change this title to "Member1, Member2 and Member3 in Company".

The text is always like this anyway: "[member name]: the message"

bmuddha commented 3 years ago

Alright, thanks, that will do :)

bmuddha commented 3 years ago

@tlle14 I think this one has been fixed (on production at least)

tlle14 commented 3 years ago

Hi @bobs4462 The issue is not fixed

image

As in this photo, It should be:

Ha Nguyen, Hieu Hoang, Tung Lam Le Cao, ... in LINAGORA
Tung Lam Le Cao: ahihihihi 
RomaricMourgues commented 3 years ago

We still not implemented this update, it should be done in some weeks. It is something only backend Twake can do :)

tlle14 commented 3 years ago

I should transfer this ticket to Twake Web team since it is the backend issue