linagora / Twake

Twake is a secure open source collaboration platform to improve organizational productivity.
https://twake.app
GNU Affero General Public License v3.0
1.77k stars 191 forks source link

[Magic Link] Unexpected behavior with other link on iOS #2117

Open huynguyennovem opened 2 years ago

huynguyennovem commented 2 years ago

Actual result

On iOS, when I click on this link https://web.twake.app/client/bDxmFx1KPWhhJeetsVj12J/w/w31iupjuCFvvbf8ewYcYg7/c/u5cSraDEmV3HnWSQSDRWxP, it opened Twake app with nothing happens

Expected

Twake app should only accept magic link with format: https://<twake-domain>?join=<invitation-code> With other Twake link, it should open browser instead

Environment

iOS emulator (Iphone 13, iOS 15.0)

RomaricMourgues commented 2 years ago

This link should work on mobile and open the right channel / workspace / company, isn't it better? We can create an issue with the full description of this routing. Our format is simple: https://web.twake.app/client/{company_id}/w/{workspace_id}/c/{channel_id}

huynguyennovem commented 2 years ago

@RomaricMourgues : Thank for recommending this. But as I can see, the current id format is different. For eg: company id: af76efe0-f59e-11eb-8210-0242ac120002

RomaricMourgues commented 2 years ago

Of course you need the lib to short / expand this format: On node: https://github.com/oculus42/short-uuid On flutter: https://pub.dev/packages/short_uuids