linagora / Twake

Twake is a secure open source collaboration platform to improve organizational productivity.

https://twake.app

GNU Affero General Public License v3.0

1.79k stars 195 forks source link

🛠 Fix update workspace info #2455

Closed oubchid closed 2 years ago

oubchid commented 2 years ago

Related Issue

2358

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added the Signed-off-by statement at the end of my commit message.

oubchid commented 2 years ago

Doesn't seems right to me, did you test this scenarios:

change the logo of a workspace that already have a logo

remove the logo when there is a logo

add a logo to a workspace that just been created

The PR fix is about the update issue (when you update only name info the logo is deleted). So the two senarios are already tested.

I can check the 3rd one. EDIT: the 3rd one works too