linagora / Twake

Twake is a secure open source collaboration platform to improve organizational productivity.
https://twake.app
GNU Affero General Public License v3.0
1.79k stars 195 forks source link

Invitation process update #2552

Open RomaricMourgues opened 2 years ago

RomaricMourgues commented 2 years ago

US: https://www.notion.so/linagora/Invitation-process-a7e8333bf0ab4aeb9f88158d38197832

Context

This popup is triggered when inviting users to the workspace from the workspace parameters screen (or the "invite users" shortcut).

It will also be available as a shortcut when typing an unknown email in the channel invitation modal.

New UI and atoms

A lot of atoms for the new UI already exists in the storybook: https://staging-web.twake.app/storybook/index.html

For this modal will be needed:

Missing (todo)

What to do then

Note: As far as I can see the backend APIs already exists, maybe it would be preferable to create a single endpoint to avoid calling several time multiple apis.

Screenshot 2022-10-03 at 10 44 19

Do not forget to:

RomaricMourgues commented 2 years ago

For the "invite anyone with this email domain"

Create one entity and update the Workspace entity:

WorkspaceInviteDomain {
  domain: string;
  company_id: string;
  workspace_id: string;
} 
Workspace {
  id: string;
  company_id: string;
  name: string;
  + preferences: null | {
    "invite_domain": null | string
  } 
} 

Functional logic

tprudentova commented 1 year ago

Hello!

  1. First letter in “Invite people to” should be capital Screenshot 2022-10-28 at 13.22.03.png
  2. “Copy” doesn’t copy the link to clipboard https://images.zenhubusercontent.com/271994210/746b1b03-3de1-4d71-a5cd-a50393daaf9c/screen_recording_2022_10_28_at_13_28_38.mov
  3. Impossible to uncheck the option of inviting all users of the same domain https://images.zenhubusercontent.com/271994210/dc8c1493-863a-413d-8256-78a88653f72d/screen_recording_2022_10_28_at_14_06_36.mov
  4. Capital letter and maybe something like “Choose channels” would sound better? Screenshot 2022-10-28 at 14.12.50.png
  5. Impossible to uncheck chosen channels https://images.zenhubusercontent.com/271994210/673735cc-fe00-4912-8f53-f6e357d8b9fa/screen_recording_2022_10_28_at_14_14_02.mov
  6. User has only one channel in a workspace but when they’re trying to invite someone, it’s suggested that there are 2 default channels https://images.zenhubusercontent.com/271994210/7bfa5414-ac15-4963-baa8-9682bac71214/screen_recording_2022_10_28_at_15_07_19.mov
  7. Impossible to add a user, the line is simply highlighted red after you try to add them. It happens both when the user is in the company and not https://images.zenhubusercontent.com/271994210/1dd2ae46-c46f-4986-b0d9-2b31422ba839/screen_recording_2022_11_02_at_13_49_24.mov
  8. Bulk invitation: no button to add users, “enter” also doesn’t help. Screenshot 2022-11-02 at 13.42.40.png
  9. Bulk invitation: text you enter starts at the very beginning of the line box which looks a bit weird
tprudentova commented 1 year ago
  1. Fixed
  2. A notification “link copied to clipboard” appears, but it actually is not https://images.zenhubusercontent.com/271994210/d8c7740e-62a2-47f9-ab06-a851d9e4cc67/copy_correct_.mov
  3. Bug still there, it’s absolutely impossible to dismiss this feature once you check this box
  4. Fixed
  5. Fixed
  6. Bug still there
  7. Fixed

A new one:

  1. “Check invitation status” is highlighted in blue so it looks like it should be cklickable, but it’s not. Also there’s no “Member management” tab in Workspace settings, so it might be a bit confusing for a user. Aaand there’s also a space missing after the two dots. Screenshot 2022-11-30 at 13.46.54.png Screenshot 2022-11-30 at 13.47.20.png
  2. Text in the search box is cropped out Screenshot 2022-11-30 at 14.03.44.png