search

linagora / Twake

Twake is a secure open source collaboration platform to improve organizational productivity.
https://twake.app
GNU Affero General Public License v3.0
1.79k stars 195 forks source link

Bugs: notifications and badges #2656

Open tprudentova opened 1 year ago

tprudentova commented 1 year ago
  1. User gets a +1 badge when he himself sends a message to a chat https://images.zenhubusercontent.com/271994210/a5369020-df8f-403a-985a-81ffc90f6adb/screen_recording_2022_12_08_at_10_12_53.mov
  2. There are still no push notifications when someone reacts to a message
  3. Notification badges look as if a user has been tagged in a chat, though he’s been not Screenshot 2022-12-08 at 10.17.10.png Screenshot 2022-12-08 at 10.17.20.png
  4. User only has @ notifications enabled. When they click on a chat, the correct counter changes to the total number of new messages including muted ones for a few secs https://images.zenhubusercontent.com/271994210/a78e8730-61ad-4ab9-86f6-5f7b8a1a3370/screen_recording_2022_12_08_at_10_46_32.mov
  5. As I see in the design, there should be grey badges when a certain type of message is muted, but at the moment there are only blue ones. User sees no badge at all if the received message type is muted
RomaricMourgues commented 1 year ago

For 2 can you confirm you have still the bug knowing that you should not receive a reaction notification if:

For 5 I think it is related to some delay or rerender bug (which is a bug then), could you confirm ? A way to for refresh this is to go to "channel settings" and add/remove from favorites

For 1, 3 and 4 yes we'll fix it thanks

tprudentova commented 1 year ago

Considering 2, I finally found out what the problem was! I wasn’t receiving push notifications upon reactions in Safari because I had content blockers enabled which are turned on by default. So they weren’t coming thorough with these settings

Screenshot 2022-12-16 at 00 44 57

But started coming through with these

Screenshot 2022-12-16 at 00 44 38

Push notifications for messages were coming through even with blockers enabled. Looks like Safari sees reaction notifications specifically as an add for some reason?

Considering 5 – refreshing it gave a funny result – the “grey” badges are only refreshed after you change notification settings

https://user-images.githubusercontent.com/97684890/208047818-bf66efdc-40bb-4f1e-8de0-7789befbb882.mov